]> dgit.raspbian.org Git - gnome-shell.git/commit
mpris: Validate received data against the expected types from the spec
authorPhilip Chimento <philip@endlessm.com>
Tue, 29 Oct 2019 00:06:40 +0000 (17:06 -0700)
committerFlorian Müllner <florian.muellner@gmail.com>
Tue, 29 Oct 2019 19:25:16 +0000 (19:25 +0000)
commit975280fc50651bd67c3551840cf3026b2d75a33b
tree0ce01062f2a26358992ad3b2b48ea31c66218f84
parent39e6fc9e9d948897f141a83b68c206f4db9e4961
mpris: Validate received data against the expected types from the spec

In the wild we have buggy clients (notably Chromium 77 and earlier) that
send metadata with the wrong types. Previously, this would throw an
exception and prevent the MPRIS information from showing up in the
message list.

This changes the code to check if any incoming metadata is of the type
it is expected to be, and logs a warning if not, then continues on with
a default value.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1362
js/ui/mpris.js